Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the XCode Archive time 10 times longer. #5

Open
farmer00317558 opened this issue May 21, 2023 · 11 comments
Open

Makes the XCode Archive time 10 times longer. #5

farmer00317558 opened this issue May 21, 2023 · 11 comments

Comments

@farmer00317558
Copy link

Hi, thanks for your work on this library.

I found that this library makes the XCode Archive time 60 times longer than before. Before I used this library, it took 40s to archive my application(an macOs application), but now it takes 40 minutes.

@jokimina
Copy link

image

same here

@JerryFans
Copy link

I have the same problem too in latest 1.0.3 . It archive time 40 minute. (Before is about 1minute)。

@alvin-7
Copy link

alvin-7 commented May 28, 2023

I have the same problem too in latest 1.0.3 . It archive time 40 minute. (Before is about 1minute)。

me too

@JerryFans
Copy link

Also can use my copy packages to fix this issue. https://github.com/JerryFans/flutter_tiktoken. And is Published to flutter pub.

@terryokay
Copy link

Also can use my copy packages to fix this issue. https://github.com/JerryFans/flutter_tiktoken. And is Published to flutter pub.

This Helped me. Thanks a lot.

@trevorwang
Copy link

@JerryFans Could you explain the root cause for increasing building time?

@JerryFans
Copy link

@JerryFans Could you explain the root cause for increasing building time?

In the past, there were four final map inside to match tokens usage, each with more than 100,000 lines of keys. Resulting in very slow compilation. I split the four map into dozens of small json files (In order to prevent oom), and initialized the json into the original map in the main function and can fix this issue.

@trevorwang
Copy link

Got it. Thanks for the explanation. @JerryFans

@davidmigloz
Copy link

Thanks for suggesting a fix @JerryFans. It would be nice if you can issue a PR with the fix in this repository so that @mvitlov can release it.

@JerryFans
Copy link

Ok, I'll submit a PR later.

@tinaroh
Copy link

tinaroh commented Sep 26, 2023

Hi, curious if the fix by Jerry would be accepted?

davidmigloz added a commit to davidmigloz/langchain_dart that referenced this issue Jan 10, 2024
Switched from the tiktoken package to langchain_tiktoken in order to resolve the extremely long build-time release-mode issue.

Original issue:
mvitlov/tiktoken#5

The package owner didn't merge the pull request:
mvitlov/tiktoken#6

So we're using the forked and refactored langchain_tiktoken package instead:
https://pub.dev/packages/langchain_tiktoken

---------

Co-authored-by: David Miguel <me@davidmiguel.com>
KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this issue Apr 22, 2024
…z#285)

Switched from the tiktoken package to langchain_tiktoken in order to resolve the extremely long build-time release-mode issue.

Original issue:
mvitlov/tiktoken#5

The package owner didn't merge the pull request:
mvitlov/tiktoken#6

So we're using the forked and refactored langchain_tiktoken package instead:
https://pub.dev/packages/langchain_tiktoken

---------

Co-authored-by: David Miguel <me@davidmiguel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants