Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record surrogates: moving ZeroValue treatment to op_Implicit #16

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

mishun
Copy link
Contributor

@mishun mishun commented Mar 13, 2021

No description provided.

@mishun mishun mentioned this pull request Mar 13, 2021
Copy link
Owner

@mvkara mvkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvkara mvkara merged commit 8133194 into mvkara:develop Mar 13, 2021
@mvkara
Copy link
Owner

mvkara commented Mar 13, 2021

Now that this test case works the nested struct collection case fails.

[<Struct; TestName("Struct record with inner complex types", [| typeof<InnerNestedRecordWithCollections> |])>]
type StructRecordWithNestedTypes = {
    DataCollection: InnerNestedRecordWithCollections array
    StructDataCollection: StructRecordWithCollectionTestCases array
    Data: InnerNestedRecordWithCollections
}

@mishun
Copy link
Contributor Author

mishun commented Mar 13, 2021

Adding StructRecordWithCollectionTestCases to registration list seems to make that test case work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants