Image sampler set to linear/clamp (#158)

If a Bevy application override the default sample to repeat, Egui window backgrounds are incorrectly transparent.
mvlabat · Mar 12, 2023 · 14a0192 · 14a0192
1 parent e739d78
commit 14a0192
Showing 1 changed file with 27 additions and 19 deletions.
diff --git a/src/egui_node.rs b/src/egui_node.rs
@@ -13,17 +13,18 @@ use bevy::{
     render::{
         render_graph::{Node, NodeRunError, RenderGraphContext},
         render_resource::{
-            BindGroupLayout, BindGroupLayoutDescriptor, BindGroupLayoutEntry, BindingType,
-            BlendComponent, BlendFactor, BlendOperation, BlendState, Buffer, BufferAddress,
-            BufferBindingType, BufferDescriptor, BufferUsages, ColorTargetState, ColorWrites,
-            Extent3d, FragmentState, FrontFace, IndexFormat, LoadOp, MultisampleState, Operations,
-            PipelineCache, PrimitiveState, RenderPassColorAttachment, RenderPassDescriptor,
-            RenderPipelineDescriptor, SamplerBindingType, Shader, ShaderStages, ShaderType,
-            SpecializedRenderPipeline, TextureDimension, TextureFormat, TextureSampleType,
-            TextureViewDimension, VertexBufferLayout, VertexFormat, VertexState, VertexStepMode,
+            AddressMode, BindGroupLayout, BindGroupLayoutDescriptor, BindGroupLayoutEntry,
+            BindingType, BlendComponent, BlendFactor, BlendOperation, BlendState, Buffer,
+            BufferAddress, BufferBindingType, BufferDescriptor, BufferUsages, ColorTargetState,
+            ColorWrites, Extent3d, FragmentState, FrontFace, IndexFormat, LoadOp, MultisampleState,
+            Operations, PipelineCache, PrimitiveState, RenderPassColorAttachment,
+            RenderPassDescriptor, RenderPipelineDescriptor, SamplerBindingType, SamplerDescriptor,
+            Shader, ShaderStages, ShaderType, SpecializedRenderPipeline, TextureDimension,
+            TextureFormat, TextureSampleType, TextureViewDimension, VertexBufferLayout,
+            VertexFormat, VertexState, VertexStepMode,
         },
         renderer::{RenderContext, RenderDevice, RenderQueue},
-        texture::Image,
+        texture::{Image, ImageSampler},
         view::ExtractedWindows,
     },
 };
@@ -431,14 +432,21 @@ pub(crate) fn color_image_as_bevy_image(egui_image: &egui::ColorImage) -> Image
         .flat_map(|color| color.to_srgba_unmultiplied())
         .collect();
 
-    Image::new(
-        Extent3d {
-            width: egui_image.width() as u32,
-            height: egui_image.height() as u32,
-            depth_or_array_layers: 1,
-        },
-        TextureDimension::D2,
-        pixels,
-        TextureFormat::Rgba8UnormSrgb,
-    )
+    Image {
+        sampler_descriptor: ImageSampler::Descriptor(SamplerDescriptor {
+            address_mode_u: AddressMode::ClampToEdge,
+            address_mode_v: AddressMode::ClampToEdge,
+            ..ImageSampler::linear_descriptor()
+        }),
+        ..Image::new(
+            Extent3d {
+                width: egui_image.width() as u32,
+                height: egui_image.height() as u32,
+                depth_or_array_layers: 1,
+            },
+            TextureDimension::D2,
+            pixels,
+            TextureFormat::Rgba8UnormSrgb,
+        )
+    }
 }