Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bevy_core_pipeline to dev-dependencies #166

Merged

Conversation

jakobhellermann
Copy link
Contributor

bevy_core_pipeline is only used in the render to texture example

@jakobhellermann
Copy link
Contributor Author

I found this while looking into potential compile time improvements. Would you be open to depending on bevy crates directly? That way, on a clean compile, bevy_egui could compile immediately after bevy_render in parallel with bevy_pbr and potentially a lot of other bevy helper crates.

In this example it would save 2 seconds:
image

I can open a PR if you want.

@mvlabat
Copy link
Owner

mvlabat commented Mar 22, 2023

Great find, thank you!

Would you be open to depending on bevy crates directly?

I was hesitant about depending on subcrates, as it makes patching more cumbersome for fork users. But compile times surely have higher priority, so if the gains are significant, I'm 100% open to this.

@mvlabat mvlabat merged commit e58d928 into mvlabat:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants