Handle giving time input to egui correctly #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The predicted_dt should be based on the target framerate and not depend on frame-to-frame fluctuations. Instead, we can pass total elapsed time instead to let egui handle things correctly.
|
Hi, apologies for the delay, and thanks for the fix! |
Schmarni-Dev
pushed a commit
to Schmarni-Dev/bevy_egui
that referenced
this pull request
Dec 23, 2023
The predicted_dt should be based on the target framerate and not depend on frame-to-frame fluctuations. Instead, we can pass total elapsed time instead to let egui handle things correctly.
Schmarni-Dev
pushed a commit
to Schmarni-Dev/bevy_egui
that referenced
this pull request
Dec 23, 2023
The predicted_dt should be based on the target framerate and not depend on frame-to-frame fluctuations. Instead, we can pass total elapsed time instead to let egui handle things correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicted_dt should be based on the target framerate and not depend on frame-to-frame fluctuations. Instead, we can pass total elapsed time instead to let egui handle things correctly.