update to bevy 0.6

[jakobhellermann]

Opening this to avoid duplicated work in case someone else wants to use bevy_egui with bevy main.

[vihdzp]

Currently, trying to use this branch gives me the error that "the trait bound EguiPlugin: bevy::prelude::Plugin is not satisfied."

[aevyrie]

This: jakobhellermann#1 fixes that error.

[jakobhellermann]

This: jakobhellermann#1 fixes that error.

Thanks!

[tbarusseau]

Thanks for putting up the branch!

Even with this modification (using the latest version of the branch bevy-main), I'm getting this same error: the trait 'bevy::prelude::Plugin' is not implemented for 'EguiPlugin'.

Any idea why?

[aevyrie]

Thanks for putting up the branch!

Even with this modification (using the latest version of the branch bevy-main), I'm getting this same error: the trait 'bevy::prelude::Plugin' is not implemented for 'EguiPlugin'.

Any idea why?

I just tested after updating main, with no issue. That error means the Plugin types are not equivalent (from different upstream versions). I'd suggest a cargo clean and cargo update. Also double check you are using the bevy main branch from github.

[tbarusseau]

Duh, turns out that I didn't specify branch = main in my Cargo.toml, and even though I thought I thoroughly checked that the commit of the git repositories used were the same... I was wrong!

Thanks for the sanity check aevyrie, and thanks jakobhellermann for the PR.

[vihdzp]

I've made my own fork of this that also updates egui to 0.13.0: https://github.com/OfficialURL/bevy_egui/tree/bevy-main

[CGMossa]

I don't know how this is going, but I see that for example AppBuilder has been removed, so this needs to be updated here. Is it in this PR you'd do it?

[jakobhellermann]

@CGMossa I rebased the branch, it should work now.

[CGMossa]

Thanks. I didn't know how to do it in a better way. Please close this if you like.

…

On Thu, 29 Jul 2021, 19:42 Jakob Hellermann, ***@***.***> wrote: @CGMossa <https://github.com/CGMossa> I rebased the branch, it should work now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDVSHDFKDCNEHU2URELJDT2GHINANCNFSM44O547YQ> .

[vihdzp]

This branch does not currently work. It seems to want a bunch of lifetime arguments. There's relevant info here and here.

The solution seems to be renaming the 'a lifetimes to either 'w or 's.

[vihdzp]

I've submitted a PR to make this work in the latest Bevy commit.

[vihdzp]

I've bumped my branch to egui 0.14, in case anyone is interested.

[mvlabat]

I've just published bevy_egui 0.7.0 upgrading egui to 0.14.

[korczis]

Nice! Thanks for sharing. I was about ask if somebody works on this and if can summarize steps needed to achieve this?

So, please, can you write up some summary of steps needed to achieve this? Some details will be great.

I want to jump on it as soon as possible and help with it.

Thanks in advance.

[mvlabat]

@jakobhellermann you can remove this line to make the build green again:

bevy_egui/.github/workflows/check.yml

Line 107 in 80541c7

args: -p tracing-wasm --precise 0.2.0

It's a workaround needed for Bevy 0.5.

[Shatur]

0.6 was released!

[jakobhellermann]

I'll fix the two window example and mark the PR as ready to review 👍

[mvlabat]

Just tested it, works great (in WASM as well)! Thanks so much for your work @jakobhellermann, I can't imagine following all the Bevy changes myself. @aevyrie, @TheRawMeatball, thank you for your contributions as well.

Preparing the release!