Update to egui 0.17 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works _sometimes_, but sometimes `EguiRenderOutput` is empty when it shouldn't be. Also partial texture updates hasn't been implemented yet. And I left some log output that needs removing.
Closed
Merged
|
Thank you so much for the PR. I'm currently somewhat overwhelmed due to the war in Ukraine, and I'm planning to move to a safer place soon. Hopefully, I'll find some time to merge all the pending PRs and make a release by the end of this week. |
|
@mvlabat Please prioritize your safety over any GitHub stuff! |
|
I pushed some minor changes, mostly related to naming and cleaning up unused stuff (also found some unused stuff from previously merged PRs). The PR looks great! Thanks again @emilk |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Closes #74
Closes #75
I haven't yet figured out how to do a partial texture update (using https://docs.rs/wgpu/0.12.0/wgpu/struct.CommandEncoder.html#method.copy_buffer_to_texture), so instead I opted to store the full image, update part of it, and then recreate the full texture.