Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return egui::TextureId on removal #81

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Return egui::TextureId on removal #81

merged 1 commit into from
Apr 16, 2022

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Mar 12, 2022

I wrapped the returned id into egui::TextureId since it usable only in this context. Just for consistency with other methods.

@mvlabat
Copy link
Owner

mvlabat commented Mar 13, 2022

Oh, how did I miss to update this method too?.. Good catch, thanks.
I'll have to merge it when making the 0.13 release, as it's a breaking change.

@mvlabat mvlabat merged commit a4b6e8d into mvlabat:main Apr 16, 2022
@Shatur Shatur deleted the return-texture-id branch May 21, 2022 11:29
HackerFoo pushed a commit to HackerFoo/bevy_egui that referenced this pull request Jul 16, 2022
@Shatur @HackerFoo
Return egui::TextureId on removal (mvlabat#81)
352b48e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shatur @mvlabat