Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Fix MSAA support #4

Closed
mvlabat opened this issue Jan 2, 2021 · 2 comments · Fixed by #5
Closed

Fix MSAA support #4

mvlabat opened this issue Jan 2, 2021 · 2 comments · Fixed by #5
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mvlabat
Copy link
Owner

mvlabat commented Jan 2, 2021

Adding MSAA resource makes an application panic with the following error:

thread 'main' panicked at 'render pipeline output formats and sample counts do not match render pass attachment formats'
@mvlabat mvlabat added bug Something isn't working help wanted Extra attention is needed labels Jan 2, 2021
@mvlabat mvlabat mentioned this issue Jan 3, 2021
Merged
@mvlabat mvlabat closed this as completed in #5 Jan 3, 2021
@KHN190
Copy link

KHN190 commented Mar 12, 2021

Hi, what is the cause for the error? I had another project based on wgpu hit the same thing. By reading your commit I wasn't sure with the reason.

@mvlabat
Copy link
Owner Author

mvlabat commented Mar 12, 2021 •
edited
Loading

Hi @KHN190. I fixed it by passing sample_count to the render pipeline:

bevy_megaui/src/megaui_node.rs

Line 386 in 9c7ecd8

sample_count: msaa.samples,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.1.2 mvlabat/bevy_megaui
2 participants
@KHN190 @mvlabat