New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option in check_Xs to return the number of views, samples and features #235
Conversation
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 95.40% 95.41% +0.01%
==========================================
Files 46 46
Lines 2982 2990 +8
Branches 585 587 +2
==========================================
+ Hits 2845 2853 +8
Misses 75 75
Partials 62 62
Continue to review full report at Codecov.
|
Co-authored-by: Ronan Perry <rflperry@gmail.com>
Co-authored-by: Ronan Perry <rflperry@gmail.com>
Co-authored-by: Ronan Perry <rflperry@gmail.com>
I included your comments, thanks. |
@rflperry can you give me write access to repo please? |
thx @pierreablin |
What does this implement/fix? Explain your changes.
This adds an optional parameter
return_dimensions
inmvlearn.utils.check_Xs
so thatcheck_Xs(Xs, return_dimensions=True)
returnsXs, n_views, n_samples, n_features
.This is useful since many estimators need to store these dimensions, and it makes it easier than writing e.g.
n_features = [X.shape[1] for X in Xs]
in each file.