Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvnd does not pick the BoM from the source tree #9

Closed
ppalaga opened this issue Oct 1, 2019 · 4 comments
Closed

mvnd does not pick the BoM from the source tree #9

ppalaga opened this issue Oct 1, 2019 · 4 comments
Labels
wontfix This will not be worked on

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 1, 2019

The $subj is just my theory to explain what just happened to me:

I added a version-less dependency apt into a Maven module camel-quarkus-platform-http-component. I also added apt properly versioned into the dependencyManagement of camel-quarkus-bom in the same source tree. Note that camel-quarkus-platform-http-component imports camel-quarkus-bom. Saved all. I am about to push the code to apache/camel-quarkus#201

mvnd clean install -DskipTests run from the top directory complained about the apt version missing in camel-quarkus-platform-http-component.

Running the same goals with the stock Maven succeeded.

So I assume the smart builder is probably not linking camel-quarkus-platform-http-component as dependent on camel-quarkus-bom.

@gnodet
Copy link
Contributor

gnodet commented Oct 3, 2019

I think the problem is that something is kept in cache and not invalidated when the input has changed. I'll try to pinpoint the problem more precisely.

@gnodet
Copy link
Contributor

gnodet commented Oct 18, 2019

The actual problem is that by default the maven DefaultProjectBuilder uses a ModelCache which keeps instances of org.apache.maven.model.Model in the cache. The purpose is to avoid parsing the same pom multiple times in a reactor, but it does not take into account the fact that the local projects may have changed.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 18, 2019

What would be the best workaround? To kill the daemon? Or maybe there is a switch to restart the daemon?

@gnodet
Copy link
Contributor

gnodet commented Oct 18, 2019

I'm working on implementing a ProjectBuilder with a cache that will fix the problem.

@gnodet gnodet closed this as completed in 74f1cc0 Oct 18, 2019
ppalaga pushed a commit to ppalaga/mvnd that referenced this issue Jul 14, 2020
@ppalaga ppalaga added this to the Black hole milestone Jul 30, 2020
ppalaga added a commit to ppalaga/mvnd that referenced this issue Sep 29, 2020
@gnodet gnodet added the wontfix This will not be worked on label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants