Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity options in custom rules should not have quotes #108

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

hlprasu
Copy link
Contributor

@hlprasu hlprasu commented Nov 17, 2023

Severity options should not have quotes. Otherwise, it will be a syntax error in DRCs.

Example:

(rule "A"
  (constraint hole_clearance (min "0.5mm"))
  (severity exclusion))
             ^^^^^^^^ <- correct

(rule "A"
  (constraint hole_clearance (min "0.5mm"))
  (severity "exclusion"))
             ^^^^^^^^^ <- syntax error here

@hlprasu
Copy link
Contributor Author

hlprasu commented Nov 17, 2023

@mvnmgrx Kindly review and merge if acceptable.

@mvnmgrx mvnmgrx merged commit ef5cf33 into mvnmgrx:master Nov 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants