Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Redundant line break in a footprint's pad section #16

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

mvnmgrx
Copy link
Owner

@mvnmgrx mvnmgrx commented Jun 29, 2022

This PR implements the following to fix #15 :

  • Fixed redundant line break in a footprints pad section with a schematic symbol assigned (aka net, pinfunction or pintype token set) as well as at least the solder_paste_margin_ratio token set
  • Added test case for this that showed the wrong behavior before the fix

Tests:

✅ - 0.002s - Testing <class 'src.kiutils.libraries.LibTable'> to compare for case fp-lib-table. result: Success
✅ - 0.001s - Testing <class 'src.kiutils.libraries.LibTable'> to compare for case sym-lib-table. result: Success
✅ - 0.010s - Testing <class 'src.kiutils.schematic.Schematic'> to equality for case test.kicad_sch. result: Success
✅ - 0.023s - Testing <class 'src.kiutils.board.Board'> to equality for case test.kicad_pcb. result: Success
✅ - 0.028s - Testing <class 'src.kiutils.footprint.Footprint'> to compare for case test.kicad_mod. result: Success
✅ - 0.045s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test.kicad_sym. result: Success
✅ - 0.006s - Testing <class 'src.kiutils.footprint.Footprint'> to equality for case test_fp_all.kicad_mod. result: Success
✅ - 0.001s - Testing <class 'src.kiutils.footprint.Footprint'> to compare for case test_fp_empty_attr.kicad_mod. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_demorgan.kicad_sym. result: Success
✅ - 0.009s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_demorgan_syitems.kicad_sym. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_parameters.kicad_sym. result: Success
✅ - 0.009s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_pins.kicad_sym. result: Success
✅ - 0.006s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_alternate_pins.kicad_sym. result: Success
✅ - 0.033s - Testing <class 'src.kiutils.wks.WorkSheet'> to compare for case test_wks_all.kicad_wks. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.dru.DesignRules'> to compare for case test_dru_all.kicad_dru. result: Success
✅ - 0.016s - Testing <class 'src.kiutils.board.Board'> to compare for case test_arcs.kicad_pcb. result: Success
✅ - 0.006s - Testing <class 'src.kiutils.footprint.Footprint'> to compare for case test_fp_pad_newlines.kicad_mod. result: Success

---------------------

✅ KiUtils tests done, all green ✅

@mvnmgrx mvnmgrx merged commit 12decef into master Jun 29, 2022
@mvnmgrx mvnmgrx deleted the fix_pad_newlines branch June 29, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footprint pad inserts unwanted line break
1 participant