Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Additional layers in stackup not parsed #18

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Conversation

mvnmgrx
Copy link
Owner

@mvnmgrx mvnmgrx commented Jul 7, 2022

This PR fixes #17 and implements sublayer tokens to parse dielectric stackups in a PCB correctly.

  • Implemented class StackupSubLayer
  • Added test case for stacked dielectrics

Tests:

✅ - 0.002s - Testing <class 'src.kiutils.libraries.LibTable'> to compare for case fp-lib-table. result: Success
✅ - 0.001s - Testing <class 'src.kiutils.libraries.LibTable'> to compare for case sym-lib-table. result: Success
✅ - 0.012s - Testing <class 'src.kiutils.schematic.Schematic'> to equality for case test.kicad_sch. result: Success
✅ - 0.023s - Testing <class 'src.kiutils.board.Board'> to equality for case test.kicad_pcb. result: Success
✅ - 0.030s - Testing <class 'src.kiutils.footprint.Footprint'> to compare for case test.kicad_mod. result: Success
✅ - 0.049s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test.kicad_sym. result: Success
✅ - 0.006s - Testing <class 'src.kiutils.footprint.Footprint'> to equality for case test_fp_all.kicad_mod. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.footprint.Footprint'> to compare for case test_fp_empty_attr.kicad_mod. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_demorgan.kicad_sym. result: Success
✅ - 0.009s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_demorgan_syitems.kicad_sym. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_parameters.kicad_sym. result: Success
✅ - 0.011s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_pins.kicad_sym. result: Success
✅ - 0.006s - Testing <class 'src.kiutils.symbol.SymbolLib'> to compare for case test_sym_alternate_pins.kicad_sym. result: Success
✅ - 0.035s - Testing <class 'src.kiutils.wks.WorkSheet'> to compare for case test_wks_all.kicad_wks. result: Success
✅ - 0.002s - Testing <class 'src.kiutils.dru.DesignRules'> to compare for case test_dru_all.kicad_dru. result: Success
✅ - 0.007s - Testing <class 'src.kiutils.footprint.Footprint'> to compare for case test_fp_pad_newlines.kicad_mod. result: Success
✅ - 0.019s - Testing <class 'src.kiutils.board.Board'> to compare for case test_pcb_trace_arcs.kicad_pcb. result: Success
✅ - 0.010s - Testing <class 'src.kiutils.board.Board'> to compare for case test_pcb_stackup_dielectrics_32layer_vias.kicad_pcb. result: Success

---------------------

✅ KiUtils tests done, all green ✅

@mvnmgrx mvnmgrx merged commit 122d34d into master Jul 7, 2022
@mvnmgrx mvnmgrx deleted the fix_stackup branch July 7, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional layers on stackup page are not parsed
1 participant