Ignore comment lines #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's a bug where a comment line including a colon matches as an option, breaking the parser. The Python spec says that a comment starts with a "#" or ";" and can be preceded by whitespace, so `^\s*[#;].*$` seems like a suitable regex. https://docs.python.org/3/library/configparser.html#supported-ini-file-structure
|
Thanks for this PR! Indeed, this is a bug in the code and you PR looks great. |
zchee
pushed a commit
to unofficial-mirror/chromiumos-infra-go
that referenced
this pull request
Nov 20, 2019
The original author accepted my pull request to fix his code's issue with comments that include a ":". mvo5/goconfigparser#4 TEST=Ran it manually. This is a contrib directory. Change-Id: I5dfef6f73e324cdf401d28b1feb71c94e94d3201 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/infra/test_planner/+/1511728 Reviewed-by: Andrew Lamb <andrewlamb@chromium.org> Commit-Queue: Sean Abraham <seanabraham@chromium.org> Tested-by: Sean Abraham <seanabraham@chromium.org> Trybot-Ready: Sean Abraham <seanabraham@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/infra/go/+/1679298 Reviewed-by: Sean Abraham <seanabraham@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's a bug where a comment line including a colon matches
as an option, breaking the parser. The Python spec says that a comment
starts with a "#" or ";" and can be preceded by whitespace, so
^\s*[#;].*$seems like a suitable regex.https://docs.python.org/3/library/configparser.html#supported-ini-file-structure