Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop raising NoAllowedOriginError when marking packages to upgrade/in… #191

Merged
merged 1 commit into from Apr 18, 2019
Merged

Stop raising NoAllowedOriginError when marking packages to upgrade/in… #191

merged 1 commit into from Apr 18, 2019

Conversation

rbalint
Copy link
Collaborator

@rbalint rbalint commented Apr 15, 2019

…stall fails

LP: #1824876

julian-klode
julian-klode approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@julian-klode julian-klode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. From what I understand, this was raising the error if it could not re-adjust some packages, but others could be, and I guess it can potentially continue without that or fail properly.

@rbalint
Copy link
Collaborator Author

rbalint commented Apr 18, 2019

I aimed at better error propagation when I added the raise but handling the exception in all callers just became too painful and u-u already checks if the marked changes are OK making the exception redundant.

@rbalint rbalint merged commit 4dfbb9b into mvo5:master Apr 18, 2019
@rbalint rbalint deleted the mark-pkgs-to-upgrade branch April 18, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-klode julian-klode julian-klode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rbalint @julian-klode