Protect unattended-upgrades from stopping early #64
Conversation
debian/control
Outdated
| @@ -14,7 +14,7 @@ XS-Testsuite: autopkgtest | |||
| Package: unattended-upgrades | |||
| Architecture: all | |||
| Depends: ${shlibs:Depends}, ${misc:Depends}, debconf, python3, | |||
| python3-apt, apt-utils, apt, ucf, lsb-release, lsb-base (>= 3.2-14), | |||
| python3-apt, apt-utils, apt (>= 1.4.2~), ucf, lsb-release, lsb-base (>= 3.2-14), | |||
There was a problem hiding this comment.
This is slightly problematic - I would like unattended-upgrades to be trivially backportable as far as possible. This is why it runs under both py2 and py3 and does not use advanced python-apt features. If we can avoid making this a hard dependencies and instead do runtime detection of whatever it is we need, I would prefer that. I'm not far enough into the PR yet to see why this is needed :)
There was a problem hiding this comment.
I'm proposing a patch against apt instead and u-u then can drop the versioned dependency.
Please don't merge before I update this PR.
Also place unattended-upgrade pid file early and remove it on exit. LP: #1690980
|
Please follow this Launchpad bug to see if the apt patch gets accepted, this PR relies on the apt KillMode and timeout changes: |
After the first 10 minute is up send graceful termination signal to u-u to give it a chance to properly shut down before systemd kills it if it does not terminate in the next 5 minutes.
rbalint
changed the title
rbalint
changed the title
Also protect the phase fixing broken installs