Implement bootstrap as MSBuild task #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- Improve performance by running bootstrap in-process and will make implementing .NET Core builds (#18) easier. Modifications ------------- Add Aspekt.Bootstrap.Tasks assembly, and change Aspekt NuGet package to use this task instead of Aspekt.Bootstrap.Host. Add build property to allow consumers to disable automatic bootstrap, as well as some points for build customization. Update Bootstrap to accept a list of referenced assemblies, which are resolved using PreregisteredAssemblyResolver. This supports bootstrap in the obj folder instead of the bin folder, accepting the list of assemblies located in other folders from MSBuild. Results -------- Consumers have the bootstrap performing in-process. Still only works on MSBuild Full flavor, not the MSBuild Core flavor. *Note:* Test assemblies are still using Aspekt.Bootstrap.Host due to problems with file locks being held by MSBuild in Visual Studio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve performance by running bootstrap in-process and will make
implementing .NET Core builds (#18) easier.
Modifications
Add Aspekt.Bootstrap.Tasks assembly, and change Aspekt NuGet package
to use this task instead of Aspekt.Bootstrap.Host.
Add build property to allow consumers to disable automatic bootstrap,
as well as some points for build customization.
Update Bootstrap to accept a list of referenced assemblies, which are
resolved using PreregisteredAssemblyResolver. This supports bootstrap
in the obj folder instead of the bin folder, accepting the list of
assemblies located in other folders from MSBuild.
Results
Consumers have the bootstrap performing in-process. Still only
works on MSBuild Full flavor, not the MSBuild Core flavor.
Note: Test assemblies are still using Aspekt.Bootstrap.Host due to
problems with file locks being held by MSBuild in Visual Studio.