-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the API url that getData forms no longer seems to work #13
Comments
Thank you @FranciscoG, it allowed me to fix a discord bot ;) Did the same thing, I removed &page= |
This happened to me too, I decided I'm not going to deal with this out of date unpromisified library, so I switched to another urban dictionary lib which I have found much better. |
yeah i completely removed it and I'm just hitting the api myself https://github.com/FranciscoG/DerpyBot/blob/master/bot/commands/fun/urban.js |
Fixes tests and fixes mvrilo#13
When I do this:
Dictionary.fn.getData @ https://github.com/mvrilo/urban/blob/master/lib/urban.js#L66
The above script will create a URL for the GET request and it doesn't work anymore
http://api.urbandictionary.com/v0/define?page=undefined&term=catfish
However
if you remove
page=undefined
though, it workshttp://api.urbandictionary.com/v0/define?term=catfish
Is anyone else experiencing this? this lib just completely stopped working for me recently and it's just for this small reason.
The text was updated successfully, but these errors were encountered: