New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System font used in some messages #472

Closed
siritinga opened this Issue Apr 7, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@siritinga

siritinga commented Apr 7, 2015

Hi again :)
I was playing with the custom font (from http://www.freejapanesefont.com/ , a very nice place to get fonts!) and it works great :) however, using a different font it is easy to spot where it is not being used. I found two places:
When searching, in the message "Searching 直る":
2015-04-07 16 28 10

And if there is Japanese in the English translations. I suppose this is harder to fix because using the custom font for the whole message would be ugly (Latin characters in Japanese fonts usually are ugly and monospaced). For this it may be useful to set the Locale of the application to Japanese, but I don't know if doing this will force a 4.x version of Android:
2015-04-07 16 28 46

Regards.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Apr 8, 2015

Owner

Hi, thanks for the link - great site with nice fonts! Regarding the locale setting: Unfortunately there is no application setting to change the locale - you would have to change your phone's locale to Japanese to show fonts correctly.
If I change the font for the "Searching for: foo" label to Japanese, Android will for some reason start cutting off bottoms of the Latin letters (basically anything below the letter baseline). You can see this behavior in Settings / Dictionaries / Dictionary Manager (attaching a screenshot). Perhaps I should make this configurable? That is, either you will see jp chars correctly but latin letters will look chopped, or you will see chinese characters :)

Owner

mvysny commented Apr 8, 2015

Hi, thanks for the link - great site with nice fonts! Regarding the locale setting: Unfortunately there is no application setting to change the locale - you would have to change your phone's locale to Japanese to show fonts correctly.
If I change the font for the "Searching for: foo" label to Japanese, Android will for some reason start cutting off bottoms of the Latin letters (basically anything below the letter baseline). You can see this behavior in Settings / Dictionaries / Dictionary Manager (attaching a screenshot). Perhaps I should make this configurable? That is, either you will see jp chars correctly but latin letters will look chopped, or you will see chinese characters :)

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny
Owner

mvysny commented Apr 8, 2015

device-2015-04-08-172649

@siritinga

This comment has been minimized.

Show comment
Hide comment
@siritinga

siritinga Apr 8, 2015

I see! Certainly, it is better to have good romaji and ocassionally a bad kanji :)

Regarding the Locale, I read that it can be selected with http://developer.android.com/reference/android/widget/TextView.html#setTextLocale%28java.util.Locale%29 but it may limit the Android version that Aedict can run on. I'm not an Android developer, I cannot help you there :(

siritinga commented Apr 8, 2015

I see! Certainly, it is better to have good romaji and ocassionally a bad kanji :)

Regarding the Locale, I read that it can be selected with http://developer.android.com/reference/android/widget/TextView.html#setTextLocale%28java.util.Locale%29 but it may limit the Android version that Aedict can run on. I'm not an Android developer, I cannot help you there :(

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Apr 9, 2015

Owner

This is interesting, thanks for letting me know. I did not know that the TextView.setTextLocale method exists. It is indeed limited to Android 4.2 and higher, but I can simply not call this function on Android 4.1 and older, so it should be possible. I'll play with this and I'll let you know.

Owner

mvysny commented Apr 9, 2015

This is interesting, thanks for letting me know. I did not know that the TextView.setTextLocale method exists. It is indeed limited to Android 4.2 and higher, but I can simply not call this function on Android 4.1 and older, so it should be possible. I'll play with this and I'll let you know.

@mvysny

This comment has been minimized.

Show comment
Hide comment
@mvysny

mvysny Apr 9, 2015

Owner

It works ;) Fixed in Aedict 3.16, please reopen if there are still some texts (besides the topmost Action Bar) on Android 4.2 and higher which do not render JP characters correctly.

Owner

mvysny commented Apr 9, 2015

It works ;) Fixed in Aedict 3.16, please reopen if there are still some texts (besides the topmost Action Bar) on Android 4.2 and higher which do not render JP characters correctly.

@mvysny mvysny closed this Apr 9, 2015

@siritinga

This comment has been minimized.

Show comment
Hide comment
@siritinga

siritinga Apr 11, 2015

Thank you! I'll try as soon as I can update it :)

siritinga commented Apr 11, 2015

Thank you! I'll try as soon as I can update it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment