Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Nextcloud 15 #53

Closed
u63725 opened this issue Mar 28, 2019 · 12 comments
Closed

Problems with Nextcloud 15 #53

u63725 opened this issue Mar 28, 2019 · 12 comments

Comments

@u63725
Copy link

u63725 commented Mar 28, 2019

55079028-adf24700-509b-11e9-85d8-1f657fab8035

I have this Problem on my Nextcloud 15. I tried occ maintenance:theme:update and also clearing the Browser cache (ctrl + F5)

@mwalbeck
Copy link
Owner

Thanks for reporting back.

If you know how, could you open the HTML inspection tool and see if the CSS is being overwritten by something or if it is never applied.

I'm inclined to believe it's the former as some styling from the theme is applied. It might be a browser plugin that's the culprit. Let me know what you find.

@u63725
Copy link
Author

u63725 commented Mar 28, 2019

I have open the HTML inspection tool. Is there anything you need to find the error?

@mwalbeck
Copy link
Owner

Great, if you look at the id selector #controls and its background-color value. It's set to a variable, all the variable definitions are at the bottom so if you scroll all the way down and find the instance of --color-main-background-translucent that isn't crossed over and send me a screenshot of that. I've added a screenshot that hopefully helps a bit.
image

Secondly, I can from your screenshot that it seems the Custom CSS plugin is in use, is that correct? If so could you try to disable it and see if that changes anything

@rcdailey
Copy link

I wanted to pitch in and say I'm seeing this exact same issue on Nextcloud 16 Beta. I do have the Custom CSS plugin enabled, but I actually use it:

#header .header-shared-by {
  display: none;
}

#body-public footer {
  display: none;
}

I use this CSS to hide some of the stuff you see on the page for public file share links. I do not want to disable this.

@rcdailey
Copy link

Also: Disabling Custom CSS didn't change anything for me

@rcdailey
Copy link

@mwalbeck I think this is what you were asking for?

image

@rcdailey
Copy link

rcdailey commented Mar 28, 2019

Ah, if I disable the Accessibility app/plugin, that fixes the issue.

Maybe this theme should work with the Accessibility app enabled and just override the user's CSS instead of assuming only the server CSS is present?

@mwalbeck
Copy link
Owner

Great find, it seems if you have enabled either the high contrast theme or the dyslexia font from the accessibility app, together with this theme you see this issue.

One of the reason why I haven't enforced the theme styling more heavily is to allow the theming app to work and even the Custom CSS app.

Do you have a specific use case where you use either the high contrast theme or the dyslexia font with this theme?

@rcdailey
Copy link

rcdailey commented Mar 29, 2019 via email

@mwalbeck
Copy link
Owner

Indeed and I should be easily able to accommodate the dyslexia font, but having a high contrast version that you can turn on/off might not be possible but I'll have to check.

What I can do is to make the theme itself more accessible in general when it comes to color and contrast. If there are any users there might benefit from it. So I'll open a new issue for that specific topic and probably have a look at that for NC 16 as it's probably going to be a big change.

@HydrexHD does disabling the High Contrast theme under accessibility options fix the issue for you?

@u63725
Copy link
Author

u63725 commented Mar 29, 2019

I fix it by disabling the High Contrast theme. Thanks.

@mwalbeck
Copy link
Owner

Great @HydrexHD I removed your second screenshot as your domain was still visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants