Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background image not showing when Nextcloud runs in sub folder of domain #97

Closed
efelon opened this issue Feb 18, 2020 · 7 comments
Closed
Labels

Comments

@efelon
Copy link

efelon commented Feb 18, 2020

Describe the bug
When running the nextcloud installation in a sub folder of the domain (mydomain.de/nc) the background image for the login is not displayed.

Setup (please complete the following information):

  • Nextcloud version: 18.0.1
  • Theme version: 18.0.6
  • Browser and browser version Firefox, Chrome, ...

Additional context
When I manually add the subfolder "nc" to the guest.css like this, it is working:

#body-login {
    background-image:
        url('/nc/apps/theming/image/background'),
        url('/core/img/background.png') !important;
   [...]
}

(original url: /apps/theming/image/background)

The styles from the regular theming show already the correct path but get overwritten by the guest.cc.

@efelon efelon added the bug label Feb 18, 2020
@mwalbeck
Copy link
Owner

Thanks for reporting this. It'll probably make sense to specify the custom background location as a relative path instead of absolute. I'll have a look and get it fixed.

@efelon
Copy link
Author

efelon commented Feb 18, 2020

Yor're welcome, I'm happy to help. Let me add a little observation, although I'm not sure it is even related.
When visiting the nextcloud login page. At first for a few milliseconds (depending on your network connection I assume) the custom "Theming Color" is shown before the background image is loaded. Maybe you have some ideas if this can be fixed as well.

mwalbeck added a commit that referenced this issue Feb 22, 2020
…nds don't use colour from theming app as background
@mwalbeck
Copy link
Owner

I've have changed the background paths to relative ones, which should hopefully fix it. it will be in the next release, hopefully, out sometime this upcoming week.

I also had a look at the background colour on the login screen. I changed it so the background-color is always the main background for the theme, and therefore should look less out of place.

@mwalbeck
Copy link
Owner

Actually while I'm working on another issue for the upcoming release, could you verify my change works as intended? I've changed the path to

../../../apps/theming/image/background

@efelon
Copy link
Author

efelon commented Feb 24, 2020

@mwalbeck Yes and thanks, this path works. If you can test it with a installation in the webroot, then this can be closed.

@mwalbeck
Copy link
Owner

Great, thanks for testing. It works as intended with with a webroot setup. I'll go ahead and close the issue when the next release is published.

@mwalbeck
Copy link
Owner

New release has just been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants