Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra _non-star label for artifact task #60

Merged
merged 1 commit into from Nov 21, 2022
Merged

Conversation

camallen
Copy link
Collaborator

@camallen camallen commented Nov 21, 2022

T15 artifact only has 6 answers in the workflow, i'm not sure where this data column came from, perhaps an older workflow version?

It appears this is in the test aggregation results for GZ CD workflow id 21802 but i'm wondering if it's meant to be here.

If it is then close this PR and i'll make sure to update the KaDE catalogue outputs to include this column even though we won't have derived data as the answer isn't in the current workflow setup.

{
  "T15": {
    "help": "There are multiple types of artifacts that.....",
    "type": "single",
    "answers": [
      {
        "label": "![artifact_bleed_trail_larger.png](https://panoptes-uploads.zooniverse.org/project_attached_image/7c826151-ae85-4151-b907-90aceae04f95.png =60x) Saturation Feature (Bleed Trail)"
      },
      {
        "label": "![artifact_diffraction_spike_larger.png](https://panoptes-uploads.zooniverse.org/project_attached_image/c5b86f1b-c1b3-46e7-83a1-76f9d2f64026.png =60x) Diffraction Spike"
      },
      {
        "label": "![artifact_satellite_trail.png](https://panoptes-uploads.zooniverse.org/project_attached_image/b5baf964-6f64-4d67-b60d-bc203ca7f971.png =60x) Satellite Trail"
      },
      {
        "label": "![artifact_cosmic_ray_larger.png](https://panoptes-uploads.zooniverse.org/project_attached_image/3f3c9590-74c8-4e67-b77c-1bc80a7a4312.png =60x) Cosmic Ray"
      },
      {
        "label": "![artifact_scattered_light.png](https://panoptes-uploads.zooniverse.org/project_attached_image/61aef8bd-7f4a-4074-9d43-49d5c927df5b.png =60x) Scattered Light"
      },
      {
        "label": "![artifact_other_mix.png](https://panoptes-uploads.zooniverse.org/project_attached_image/d0d98935-4686-4b40-9353-c910b7539ef8.png =60x) Other / Not Sure"
      }
    ],
    "question": "What type of artifact is it?",
    "required": true
  }
}

T15 `artifact` only has 6 answers in the workflow
```
{
	"T15": {
		"help": "There are multiple types of artifacts that.....",
		"type": "single",
		"answers": [
			{
				"label": "![artifact_bleed_trail_larger.png](https://panoptes-uploads.zooniverse.org/project_attached_image/7c826151-ae85-4151-b907-90aceae04f95.png =60x) Saturation Feature (Bleed Trail)"
			},
			{
				"label": "![artifact_diffraction_spike_larger.png](https://panoptes-uploads.zooniverse.org/project_attached_image/c5b86f1b-c1b3-46e7-83a1-76f9d2f64026.png =60x) Diffraction Spike"
			},
			{
				"label": "![artifact_satellite_trail.png](https://panoptes-uploads.zooniverse.org/project_attached_image/b5baf964-6f64-4d67-b60d-bc203ca7f971.png =60x) Satellite Trail"
			},
			{
				"label": "![artifact_cosmic_ray_larger.png](https://panoptes-uploads.zooniverse.org/project_attached_image/3f3c9590-74c8-4e67-b77c-1bc80a7a4312.png =60x) Cosmic Ray"
			},
			{
				"label": "![artifact_scattered_light.png](https://panoptes-uploads.zooniverse.org/project_attached_image/61aef8bd-7f4a-4074-9d43-49d5c927df5b.png =60x) Scattered Light"
			},
			{
				"label": "![artifact_other_mix.png](https://panoptes-uploads.zooniverse.org/project_attached_image/d0d98935-4686-4b40-9353-c910b7539ef8.png =60x) Other / Not Sure"
			}
		],
		"question": "What type of artifact is it?",
		"required": true
	}
}
```
Copy link
Owner

@mwalmsley mwalmsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cam. This was from pre-launch classifications that included that answer - I guess the team changed it.

@mwalmsley mwalmsley merged commit 0a4cc06 into dev Nov 21, 2022
@mwalmsley mwalmsley deleted the t15-labels-update branch November 21, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants