Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #9

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Master #9

merged 2 commits into from
Feb 22, 2020

Conversation

mwanjajoel
Copy link
Owner

Title of Pull Request

Make develop branch default

<!--- Provide a general summary of your changes in the Title above -->
Making the develop branch default is to keep master for production ready releases and develop for development releases.

Description

<!--- Describe your changes in detail -->
Making the develop branch default instead of master.

Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
It keeps the development on develop branch and releases on master branch, better standard practice.

<!--- If it fixes an open issue, please link to the issue here. -->
N/A

How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
N/A

<!--- Include details of your testing environment, and the tests you ran to -->
N/A

<!--- see how your change affects other areas of the code, etc. -->

Screenshots (if appropriate):

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. -->

<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

arthurarty and others added 2 commits February 22, 2020 12:41
- Create .env_example.
- Move env variables from settings.py to .env file.
- Install python-dotenv.
@mwanjajoel mwanjajoel merged commit 2c5afbc into develop Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants