Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated url() calls with re_path() #163

Merged

Conversation

dominik-bln
Copy link

Calls to url() are deprecated since Django 3.1 and are supposed
to be replaced with re_path().

Calls to url() are deprecated since Django 3.1 and are supposed
to be replaced with re_path().
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.975% when pulling 1157edb on dominik-bln:replace-deprecated-url-calls into 8b9d560 on mwarkentin:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.975% when pulling 1157edb on dominik-bln:replace-deprecated-url-calls into 8b9d560 on mwarkentin:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.975% when pulling 1157edb on dominik-bln:replace-deprecated-url-calls into 8b9d560 on mwarkentin:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.975% when pulling 1157edb on dominik-bln:replace-deprecated-url-calls into 8b9d560 on mwarkentin:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.975% when pulling 1157edb on dominik-bln:replace-deprecated-url-calls into 8b9d560 on mwarkentin:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.975% when pulling 1157edb on dominik-bln:replace-deprecated-url-calls into 8b9d560 on mwarkentin:master.

@ulgens
Copy link

ulgens commented Aug 26, 2020

Why not just go with path?

@dominik-bln
Copy link
Author

dominik-bln commented Aug 26, 2020

re_path is the recommended replacement of url, so to be honest this change was the easiest way to fix the deprecation warnings we are seeing without the risk of breaking something in a code base I don't know that well:

https://docs.djangoproject.com/en/3.1/ref/urls/#url

@mwarkentin
Copy link
Owner

@dominik-bln thanks for the contribution! I'll try to take a look soon.

Copy link
Owner

@mwarkentin mwarkentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominik-bln LGTM! I'll try to get a release out soon.

@mwarkentin mwarkentin merged commit cbbe1d8 into mwarkentin:master Sep 17, 2020
@mwarkentin
Copy link
Owner

@dominik-bln thanks for your patience, I've released 1.2.0 today.

@dominik-bln
Copy link
Author

Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants