add black lint workflow #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarkentin
force-pushed
the
black-fmt
branch
from
b7d8d92
to
4c3e356
Compare
ulgens
reviewed
Dec 22, 2021
| @@ -0,0 +1,10 @@ | |||
| name: Lint | |||
|
|
|||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
This will trigger duplicate check runs.
There was a problem hiding this comment.
This is the recommended config in the black docs.
According to this community post, they are actually testing two independent refs:
The workflow triggered by push and pull_request use different GITHUB_REF. When push to a branch ,the GITHUB_REF of workflow run triggered by push event is the current branch. And workflow run triggered by pull_request event uses refs/pull/:prNumber/merge as its GITHUB_REF.
If I'm reading that right, push will test the head of the current branch, and pull_request will test the branch merged into main?
fix unused imports ignore unused import in manage.py as its used to trigger an ImportError
mwarkentin
force-pushed
the
black-fmt
branch
from
e4713a0
to
1f9ae6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.