Skip to content

Commit

Permalink
Handle color an alpha provisionally
Browse files Browse the repository at this point in the history
  • Loading branch information
mwaskom committed May 21, 2018
1 parent e3930c1 commit e933619
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions seaborn/basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -745,14 +745,14 @@ def __init__(self,
self.parse_style(plot_data["style"], markers, None, style_order)
self.units = units

self.alpha = alpha

self.legend = legend

def add_legend_data(self, ax):
"""Add labeled artists to represent the different plot semantics."""
# TODO duplicating from LinePlotter; this can be substantially
# abstracted but it will be slightly trikcy
verbosity = self.legend
# TODO Use False or None?
if verbosity not in ["brief", "full"]:
err = "`legend` must be 'brief', 'full', or False"
raise ValueError(err)
Expand Down Expand Up @@ -826,9 +826,13 @@ def plot(self, ax, kws):
orig_c = kws.pop("c", scout.get_facecolors())
scout.remove()

kws.pop("color", None) # TODO is this optimal?

kws.setdefault("linewidth", .75) # TODO scale with marker size?
kws.setdefault("edgecolor", "w")

kws["alpha"] = 1 if self.alpha == "auto" else self.alpha # TODO

# Assign arguments for plt.scatter and draw the plot

data = self.plot_data
Expand Down

0 comments on commit e933619

Please sign in to comment.