Fix adjust_subtitles when legend_out=False. (#2304)

* Test adjust_subtitles and legend_out interactions * Fix adjust_subtitles when legend_out is False * Remove redundant smoke tests (cherry picked from commit a9577e7)
mwaskom · Oct 26, 2020 · f3a5628 · f3a5628
1 parent 6d8e2ad
commit f3a5628
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/seaborn/axisgrid.py b/seaborn/axisgrid.py
@@ -166,13 +166,13 @@ def add_legend(self, legend_data=None, title=None, label_order=None,
             ax = self.axes.flat[0]
             kwargs.setdefault("loc", "best")
 
-            if adjust_subtitles:
-                adjust_legend_subtitles(figlegend)
-
             leg = ax.legend(handles, labels, **kwargs)
             leg.set_title(title, prop={"size": title_size})
             self._legend = leg
 
+            if adjust_subtitles:
+                adjust_legend_subtitles(leg)
+
         return self
 
     def _clean_axis(self, ax):

diff --git a/seaborn/tests/test_axisgrid.py b/seaborn/tests/test_axisgrid.py
@@ -303,6 +303,12 @@ def test_legend_options(self):
         g1.map(plt.plot, "x", "y")
         g1.add_legend()
 
+        g1 = ag.FacetGrid(self.df, hue="b", legend_out=False)
+        g1.add_legend(adjust_subtitles=True)
+
+        g1 = ag.FacetGrid(self.df, hue="b", legend_out=False)
+        g1.add_legend(adjust_subtitles=False)
+
     def test_legendout_with_colwrap(self):
 
         g = ag.FacetGrid(self.df, col="d", hue='b',