Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersphinx #1480

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Intersphinx #1480

merged 2 commits into from
Jul 5, 2018

Conversation

arokem
Copy link
Contributor

@arokem arokem commented Jul 5, 2018

Adds intersphinx to the documentation configuration.

Also: changes to the introduction notebook to link to MPL and Pandas documentation.

@arokem
Copy link
Contributor Author

arokem commented Jul 5, 2018

If you would rather add the intersphinx config against master, we can also just cherry-pick the first of these commits into another/that branch.

@mwaskom
Copy link
Owner

mwaskom commented Jul 5, 2018

Thanks @arokem this works more smoothly than I expected! I guess sphinx embeds some metadata in the docs that lets this work?

I don't understand why it's apparently causing the tsplot doctests to fail, though.

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #1480 into update_docs will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           update_docs    #1480   +/-   ##
============================================
  Coverage        94.25%   94.25%           
============================================
  Files               15       15           
  Lines             4491     4491           
============================================
  Hits              4233     4233           
  Misses             258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b20c17...54c00be. Read the comment docs.

@arokem
Copy link
Contributor Author

arokem commented Jul 5, 2018

Yeah - each project has an objects.inv file that maps objects to their URI.

Here's seaborn's file: https://seaborn.pydata.org/objects.inv

Did you just run the CI again? Looks like it's passing now?

@mwaskom
Copy link
Owner

mwaskom commented Jul 5, 2018

Did you just run the CI again? Looks like it's passing now?

Yep I couldn't reproduce locally so I decided kicking the side of Travis and trying again might work :)

@mwaskom mwaskom merged commit 1d0009c into mwaskom:update_docs Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants