Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make font fallback work better #176

Merged
merged 2 commits into from Aug 27, 2014
Merged

Make font fallback work better #176

merged 2 commits into from Aug 27, 2014

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Apr 23, 2014

Closes #171 (cf #55)

I think this is a robust solution to the font issues. @westurner do you want to take a look?

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 23, 2014

Welp, that didn't work. I really don't understand how matplotlib handles fonts.

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 24, 2014

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 28, 2014

Based on matplotlib/matplotlib#3010 it looks like this is a problem in matplotlib itself...

@westurner
Copy link

Looks like matplotlib/matplotlib#2771 was just merged; but that pull likely won't make it into a release for quite some time.

What was the issue with prepending to font['sans-serif']? Manual visual testing indicated success. [1]

[1] westurner@617f705

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 28, 2014

The problem was that it doesn't actually work, hence the SO question/matplotlib issue...

@westurner
Copy link

The linked commit works with Ubuntu 12.04 and conda packages (out of the box w/ Arial as the default font).

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 28, 2014

I don't know what to tell you; look at the Travis logs. It clearly does not work.

@mwaskom
Copy link
Owner Author

mwaskom commented May 13, 2014

Sounds like this is going to stay broken until Matplotlib 1.4 comes out ("soon" according to @mdboom), at which point I'll merge this in and make a note that fonts may not behave as expected if using matplotlib 1.3.

@westurner
Copy link

Thanks!

Wes Turner
On May 13, 2014 11:04 AM, "Michael Waskom" notifications@github.com wrote:

Sounds like this is going to stay broken until Matplotlib 1.4 comes out
("soon" according to @mdboom https://github.com/mdboom), at which point
I'll merge this in and make a note that fonts may not behave as expected if
using matplotlib 1.3.


Reply to this email directly or view it on GitHubhttps://github.com//pull/176#issuecomment-42975416
.

mwaskom added a commit that referenced this pull request Aug 27, 2014
Make font fallback work better
@mwaskom mwaskom merged commit ad837bb into master Aug 27, 2014
@mwaskom mwaskom deleted the linux_fonts branch August 27, 2014 17:22
@westurner
Copy link

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants