Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout engine parameterization when using Plot.on #3216

Merged
merged 5 commits into from Jan 10, 2023

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jan 8, 2023

Fixes #3211

The intended behavior here was to avoid overriding the user's choice of layout engine when they provide a matplotlib object with Plot.on, but None was getting passed through to Figure.set_layout_engine which unsets the user's choice (and defers to the rc defaults).

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #3216 (f01ea33) into master (557b0d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3216   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          77       77           
  Lines       24347    24361   +14     
=======================================
+ Hits        23963    23977   +14     
  Misses        384      384           
Impacted Files Coverage Δ
seaborn/_compat.py 48.03% <100.00%> (+1.57%) ⬆️
seaborn/_core/plot.py 99.20% <100.00%> (+<0.01%) ⬆️
tests/_core/test_plot.py 98.72% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit 623b0b7 into master Jan 10, 2023
@mwaskom mwaskom deleted the fix/plot_on_layout branch January 10, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure title being removed by seaborn objects API when plotting on subfigures
1 participant