Adapt to deprecations in pandas 2.2.0 #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3620 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 75 75
Lines 24697 24706 +9
=======================================
+ Hits 24348 24357 +9
Misses 349 349
|
| @@ -2078,7 +2078,7 @@ def test_xy_native_scale_log_transform(self): | |||
|
|
|||
| def test_datetime_native_scale_axis(self): | |||
|
|
|||
| x = pd.date_range("2010-01-01", periods=20, freq="m") | |||
| x = pd.date_range("2010-01-01", periods=20, freq="MS") | |||
There was a problem hiding this comment.
FWIW if you want to have the same values as before you need "ME" (month end, not month start). Not sure whether that matters for the test, though (you test below with "2003-02-28", which is a "month end")
There was a problem hiding this comment.
Ah yeah thanks, the test date here being a "month end" is just a coincidence and not critical to the test logic.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😠