-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaned up version of siamak-haschemi's proposal for issue #85 #87
Conversation
…e AndroidManifest.xml'
- adding a dot '.' in front of the Activity name
Reflect the fact, that json2xml is specialized to generate a manifest instead of general JSON->XML-conversion (at the moment).
I tried it out your cleaned-up version. It works for me. However, since Google Play needs the 'minSdkVersion', your should consider setting it by default. Should I open a new Feature Request for that? In addition, we need to enhance the m-project docs (http://panacodalabs.github.com/The-M-Docs/#espresso/native_packaging) and the config.json docs (https://github.com/mwaylabs/Espresso/wiki/config.json). Should I open the two Issues? |
Yes, please open separate issues for That's also the reason why I removed |
cleaned up version of siamak-haschemi's proposal for issue #85
This version of siamak-haschemi's proposal for issue #85 differs in following ways:
$PATH
json2xml
tojson2manifest
to make clear that this is not a general converter at the momentjson2manifest
implicitlyObject.prototype.merge
XML.ObjTree
intoXML
node moduleminSdkVersion
isn't set by default to revert to the original behavior