Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up version of siamak-haschemi's proposal for issue #85 #87

Merged
merged 10 commits into from
May 21, 2012

Conversation

4z3
Copy link
Contributor

@4z3 4z3 commented May 20, 2012

This version of siamak-haschemi's proposal for issue #85 differs in following ways:

  • reorganize file system hierarchy in order to not clutter $PATH
  • rename json2xml to json2manifest to make clear that this is not a general converter at the moment
  • don't alter global scope in json2manifest implicitly
    • explicitly extend Object.prototype.merge
    • put XML.ObjTree into XML node module
  • minSdkVersion isn't set by default to revert to the original behavior

@siamak-haschemi
Copy link

I tried it out your cleaned-up version. It works for me.

However, since Google Play needs the 'minSdkVersion', your should consider setting it by default. Should I open a new Feature Request for that?

In addition, we need to enhance the m-project docs (http://panacodalabs.github.com/The-M-Docs/#espresso/native_packaging) and the config.json docs (https://github.com/mwaylabs/Espresso/wiki/config.json). Should I open the two Issues?

@4z3
Copy link
Contributor Author

4z3 commented May 20, 2012

Yes, please open separate issues for minSdkVersion, the m-project docs, and the config.json docs, that way each issue/feature request can be discussed separately. Furthermore each issue can be assigned to someone else.

That's also the reason why I removed minSdkVersion from the cleaned up version: it's effectively independent of the general AndroidManifest-stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants