Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

fix missing karma jasmine dependency #506

Closed
wants to merge 1 commit into from
Closed

fix missing karma jasmine dependency #506

wants to merge 1 commit into from

Conversation

funkybaboon
Copy link
Contributor

This fixes the warning of a missing dependency warning "karma-jasmine@1.1.0" has unmet peer dependency "jasmine-core@*". when running yarn on a new generator-m project.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.744% when pulling b123caa on funkybaboon:bugfix/fix_missing_karma-jasmine_dependency into c21f545 on mwaylabs:master.

@gruppjo
Copy link
Contributor

gruppjo commented Mar 22, 2017

Hi @funkybaboon. This is rather a problem of the karma-jasmine dependency and since all the tasks run fine without the peer-dep, I'd rather not include it. If this is important to you, you could investigate over at the karma-jasmine repo why they require this peer-dep.

Additionally, this is the wrong package.json file. The template of package.json of the generated project is here: https://github.com/mwaylabs/generator-m-ionic/blob/master/generators/app/templates/package.json

@gruppjo gruppjo closed this Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants