Allow easier access to site on a http:// URL

[mtausig]

Currently, the URL scheme used to access the MediaWiki instance is hardcoded to https in the raw_call function of client.py. This makes it impossible to use mwclient wit a wiki which is hosted under an unencrypted http:// URL.

This should be made configurable (either by adding a scheme parameter to the Site constructor or by allowing a full URL instead of just the hostname there).

[tosher]

https://mwclient.readthedocs.io/en/latest/user/connecting.html#connecting-to-your-site

By default, mwclient will connect using https. If your site doesn’t support https, you need to explicitly request http like so:

site = Site(('http', 'test.wikipedia.org'))

[mtausig]

Apologies. I went straight to the reference documentation of the Site class and missed this info.

[waldyrious]

Wouldn't a specific parameter be a neater way to achieve this, instead of relying on a specific, opaque data structure and the custom code to handle it?

mwclient/mwclient/client.py

Lines 367 to 370 in 030cf8a

	scheme = 'https'
	host = self.host
	if isinstance(host, (list, tuple)):
	scheme, host = host

This entire bit could be removed if host and scheme were always assigned individually (with scheme defaulting to "https", of course). That's cleaner both implementation-wise and in terms of a consistent, self-documenting API, no?

[tosher]

#198

[waldyrious]

Thanks for cross-referencing that PR, @tosher. I think the comment above still stands.

[danmichaelo]

Wouldn't a specific parameter be a neater way to achieve this, instead of relying on a specific, opaque data structure and the custom code to handle it?

I've only kept it for backwards compatibility, but I wouldn't mind if we introduced a new parameter and deprecated the old syntax and then removed it with the next major release or something.

[waldyrious]

@danmichaelo shall we reopen #213 then (and this issue as well), provided that it also removes the special handling of the host parameter in the code I quoted above?

[danmichaelo]

Yup, just re-opened #213. But perhaps keep this issue closed? At least with the current title ("Allow access to site on a http:// URL")

[mtausig]

Yup, just re-opened #213. But perhaps keep this issue closed? At least with the current title ("Allow access to site on a http:// URL")

Better now?