Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: optionally configure connection timeouts #68

Merged
merged 1 commit into from Oct 26, 2018

Conversation

bugant
Copy link
Contributor

@bugant bugant commented Aug 30, 2018

Optionally configure connection and receive timeout for network requests via two new config options: request_conn_timeout and request_recv_timeout.

Optionally configure connection and receive timeout for network requests
via two new config options: `request_conn_timeout` and
`request_recv_timeout`.
@bugant
Copy link
Contributor Author

bugant commented Aug 30, 2018

@mweibel the CI si failing for Elixir 1.3 but I cannot view what's wrong from the CI output. Can you please point to the things that mix quality does not like?

@bugant
Copy link
Contributor Author

bugant commented Oct 1, 2018

@mweibel can you help with this?

@mweibel
Copy link
Owner

mweibel commented Oct 2, 2018 via email

@mweibel
Copy link
Owner

mweibel commented Oct 11, 2018

Seems like credo doesn't support elixir 1.3 anymore. Wonder if we can get rid of that version, too. It's rather old anyway.

@bugant
Copy link
Contributor Author

bugant commented Oct 11, 2018

Yes @mweibel, I do agree, or maybe credo should be pinned (only for elixir 1.3) to an older version, I don't know if it is possible

@bugant
Copy link
Contributor Author

bugant commented Oct 25, 2018

@mweibel any news here?

@mweibel mweibel merged commit 6f9d47f into mweibel:master Oct 26, 2018
@mweibel
Copy link
Owner

mweibel commented Oct 26, 2018

Sorry it took so long. I merged it now and will fix travis setup in master. Removing elixir 1.3 and adding newer versions instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants