fix: remove tmp file after processing

mweibel · Dec 29, 2022 · ebdf1f0 · ebdf1f0
1 parent 830610d
commit ebdf1f0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/bin/lcov-result-merger.js b/bin/lcov-result-merger.js
@@ -43,13 +43,16 @@ fg.stream(args.pattern, { absolute: true })
   .pipe(lcovResultMerger(args))
   .pipe(
     through.obj((filePath) => {
-      const file = fs.openSync(filePath, 'r+');
-      const fileContentStr = fs.readFileSync(file, 'utf8');
+      const fileContentStr = fs.readFileSync(filePath, {
+        encoding: 'utf-8',
+        flag: 'r+'
+      });
+      fs.unlinkSync(filePath);
+
       if (args.outFile) {
         fs.writeFileSync(args.outFile, fileContentStr);
       } else {
         process.stdout.write(fileContentStr);
       }
-      fs.closeSync(file);
     })
   );
diff --git a/index.js b/index.js
@@ -368,20 +368,23 @@ module.exports = function (config) {
         callback();
         return;
       }
-      const file = fs.openSync(filePath, 'r');
-      const fileContentStr = fs.readFileSync(file, 'utf8');
+      const fileContentStr = fs.readFileSync(filePath, {
+        encoding: 'utf8',
+        flag: 'r'
+      });
       coverageFiles = processFile(
         path.dirname(filePath),
         fileContentStr,
         coverageFiles,
         config || {}
       );
-      fs.closeSync(file);
       callback();
     },
     function flush() {
-      const file = fs.openSync('lcov.info', 'w+');
-      fs.writeFileSync(file, Buffer.from(createRecords(coverageFiles)));
+      fs.writeFileSync('lcov.info', Buffer.from(createRecords(coverageFiles)), {
+        encoding: 'utf-8',
+        flag: 'w+'
+      });
       this.push('lcov.info');
       this.emit('end');
     }