Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of threads metered twice #116

Closed
swerner0 opened this issue Feb 23, 2021 · 3 comments · Fixed by #117
Closed

Number of threads metered twice #116

swerner0 opened this issue Feb 23, 2021 · 3 comments · Fixed by #117
Assignees
Labels
Milestone

Comments

@swerner0
Copy link

I noticed my prometheus exports had 2 thread counts listed:

# HELP process_threads The number of process threads
# TYPE process_threads gauge
process_threads 486.0

and

# HELP process_memory_threads_bytes  
# TYPE process_memory_threads_bytes gauge
process_memory_threads_bytes 486.0

The last one appears to be from the following:

Where KEY.values() contains the memory values and THREADS

@mweirauch mweirauch self-assigned this Feb 23, 2021
@mweirauch mweirauch added the bug label Feb 23, 2021
@mweirauch mweirauch added this to the 0.2.2 milestone Feb 23, 2021
@mweirauch
Copy link
Owner

Oops, how embarassing! Thanks for spotting and reporting this! I was seeing this the other day, but thought it was some actual experimental code I worked on quite a while ago in a testing project.

This was introduced with 0.2.0. I will try to come up with a fix and a release tomorrow evening.

@mweirauch mweirauch changed the title # of threads metered twice Number of threads metered twice Feb 23, 2021
@swerner0
Copy link
Author

Cool, thanks.

Yeah, no rush. Our grafana dashboards use the proper value, but did a double take when I saw the other one :-)

mweirauch added a commit that referenced this issue Feb 24, 2021
This was introduced with '0.2.0' when switching the memory metrics
retrieval to 'ProcfsStatus'.

Some cosmetics on the go.

Fixes #116.
mweirauch added a commit that referenced this issue Feb 24, 2021
This was introduced with '0.2.0' when switching the memory metrics
retrieval to 'ProcfsStatus'.

Some cosmetics on the go.

Fixes #116.
@mweirauch
Copy link
Owner

Release 0.2.2 has been synced to Maven Central. Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants