Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText.Definitions.link bad htmlToNode #27

Closed
tgelu opened this issue Oct 14, 2020 · 4 comments · Fixed by #28
Closed

RichText.Definitions.link bad htmlToNode #27

tgelu opened this issue Oct 14, 2020 · 4 comments · Fixed by #28

Comments

@tgelu
Copy link

tgelu commented Oct 14, 2020

In the Definition of link, the htmlToNode function seems to confuse href with src in here.
This has the consequence that pasting (or parsing html with a link) won't work because the link has an href not an src.

Am I missing something?
@mweiss
Copy link
Owner

mweiss commented Oct 15, 2020

That definitely looks like a bug!

@rjdellecese
Copy link
Contributor

Is the fix simply to replace "src" with "href" in that line you referenced @tgelu? If so, would you like to open a PR? If not, I would be happy to!

@mweiss
Copy link
Owner

mweiss commented Oct 30, 2020 via email

@rjdellecese rjdellecese mentioned this issue Oct 30, 2020
Merged
mweiss pushed a commit that referenced this issue Oct 31, 2020
@rjdellecese
Correct link HTML node deserialization (#28)
d60d12c 
Resolves #27
@mweiss
Copy link
Owner

mweiss commented Oct 31, 2020

Thank you so much @tgelu for reporting this and @rjdellecese for the fix! This has been published in 1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct link HTML node deserialization
3 participants
@mweiss @tgelu @rjdellecese