context: on error use lazy umount #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: mwhudson#25 When running kernel-replace 'umount -R' tends to fail. Catch the exception and use 'umount -l' in that case. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
|
While this is probably a pragmatic change, I do really hate the sort of non-deterministic approach to cleaning up mounts. Do you have any idea why the umount -R is failing? |
|
@mwhudson I was not able to identify the process that is blocking the release. Are you able to reproduce the problem? |
|
I spent a while (probably too long) trying to figure out what's going on and failing which is a bit annoying. Oh well. This is a pragmatic change. |
mvo5
added a commit
to mvo5/snappy
that referenced
this pull request
Jul 3, 2023
The existing code in writeFilesystemContent() will error when the filesystem cannot be unmounted. However in practise this is problematic as the live-system can keep the mount point busy: https://bugs.launchpad.net/snapd/+bug/2025402 As a pragmatic solution this commit unmounts the filesystem with the `--lazy` option if a normal unmount does not work. This is what live-editor is doing: mwhudson/livefs-editor#26 Alternatively we could do a bunch of retries and wait for the process that keep the filesystem busy to go away.
mvo5
added a commit
to snapcore/snapd
that referenced
this pull request
Jul 4, 2023
* install: lazy unmount() in writeFilesystemContent() if needed The existing code in writeFilesystemContent() will error when the filesystem cannot be unmounted. However in practise this is problematic as the live-system can keep the mount point busy: https://bugs.launchpad.net/snapd/+bug/2025402 As a pragmatic solution this commit unmounts the filesystem with the `--lazy` option if a normal unmount does not work. This is what live-editor is doing: mwhudson/livefs-editor#26 Alternatively we could do a bunch of retries and wait for the process that keep the filesystem busy to go away. * install: log unmount errors (thanks to Alfonso!) * install: also lazy unmount in MountVolumes() * install: fix silly typo * install: improve logging on install failure
mvo5
added a commit
to snapcore/snapd
that referenced
this pull request
Jul 4, 2023
* install: lazy unmount() in writeFilesystemContent() if needed The existing code in writeFilesystemContent() will error when the filesystem cannot be unmounted. However in practise this is problematic as the live-system can keep the mount point busy: https://bugs.launchpad.net/snapd/+bug/2025402 As a pragmatic solution this commit unmounts the filesystem with the `--lazy` option if a normal unmount does not work. This is what live-editor is doing: mwhudson/livefs-editor#26 Alternatively we could do a bunch of retries and wait for the process that keep the filesystem busy to go away. * install: log unmount errors (thanks to Alfonso!) * install: also lazy unmount in MountVolumes() * install: fix silly typo * install: improve logging on install failure
mvo5
added a commit
to snapcore/snapd
that referenced
this pull request
Jul 4, 2023
* install: lazy unmount() in writeFilesystemContent() if needed The existing code in writeFilesystemContent() will error when the filesystem cannot be unmounted. However in practise this is problematic as the live-system can keep the mount point busy: https://bugs.launchpad.net/snapd/+bug/2025402 As a pragmatic solution this commit unmounts the filesystem with the `--lazy` option if a normal unmount does not work. This is what live-editor is doing: mwhudson/livefs-editor#26 Alternatively we could do a bunch of retries and wait for the process that keep the filesystem busy to go away. * install: log unmount errors (thanks to Alfonso!) * install: also lazy unmount in MountVolumes() * install: fix silly typo * install: improve logging on install failure
alexmurray
pushed a commit
to alexmurray/snapd
that referenced
this pull request
Oct 17, 2023
…re#12939) * install: lazy unmount() in writeFilesystemContent() if needed The existing code in writeFilesystemContent() will error when the filesystem cannot be unmounted. However in practise this is problematic as the live-system can keep the mount point busy: https://bugs.launchpad.net/snapd/+bug/2025402 As a pragmatic solution this commit unmounts the filesystem with the `--lazy` option if a normal unmount does not work. This is what live-editor is doing: mwhudson/livefs-editor#26 Alternatively we could do a bunch of retries and wait for the process that keep the filesystem busy to go away. * install: log unmount errors (thanks to Alfonso!) * install: also lazy unmount in MountVolumes() * install: fix silly typo * install: improve logging on install failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #25
When running kernel-replace 'umount -R' tends to fail. Catch the exception and use 'umount -l' in that case.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de