Fix warnings in scala sources.

mwiede · Jan 22, 2023 · fa17b13 · fa17b13
1 parent 011d3c0
commit fa17b13
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 19 deletions.
diff --git a/pom.xml b/pom.xml
@@ -389,10 +389,13 @@
                     <recompileMode>all</recompileMode>
                     <sendJavaToScalac>false</sendJavaToScalac>
                     <args>
+                        <arg>-release</arg>
+                        <arg>8</arg>
                         <arg>-deprecation</arg>
                         <arg>-feature</arg>
                         <arg>-unchecked</arg>
-                        <arg>-Xfatal-warnings</arg>
+                        <arg>-Xlint</arg>
+                        <arg>-Werror</arg>
                     </args>
                 </configuration>
                 <executions>

diff --git a/src/test/scala/DeflateInflateTest.scala b/src/test/scala/DeflateInflateTest.scala
@@ -8,14 +8,14 @@ import matchers.should._
 import JZlib._
 
 class DeflateInflateTest extends AnyFlatSpec with BeforeAndAfter with Matchers {
-  val comprLen = 40000
-  val uncomprLen = comprLen
-  var compr:Array[Byte] = _
-  var uncompr:Array[Byte] = _
+  private val comprLen = 40000
+  private val uncomprLen = comprLen
+  private var compr:Array[Byte] = _
+  private var uncompr:Array[Byte] = _
 
-  var deflater: Deflater = _
-  var inflater: Inflater = _
-  var err: Int = _
+  private var deflater: Deflater = _
+  private var inflater: Inflater = _
+  private var err: Int = _
 
   before {
     compr = new Array[Byte](comprLen)
@@ -33,8 +33,6 @@ class DeflateInflateTest extends AnyFlatSpec with BeforeAndAfter with Matchers {
   behavior of "Deflter and Inflater"
 
   it can "deflate and infate data in the large buffer." in {
-    val data = "hello, hello!".getBytes
-
     err = deflater.init(Z_BEST_SPEED)
     err should equal (Z_OK)
 

diff --git a/src/test/scala/DeflaterInflaterStreamTest.scala b/src/test/scala/DeflaterInflaterStreamTest.scala
@@ -9,8 +9,6 @@ import scala.language.reflectiveCalls
 
 import java.io.{ByteArrayOutputStream => BAOS, ByteArrayInputStream => BAIS}
 
-import JZlib._
-
 class DeflaterInflaterStreamTest extends AnyFlatSpec with BeforeAndAfter with Matchers {
 
   before {

diff --git a/src/test/scala/WrapperTypeTest.scala b/src/test/scala/WrapperTypeTest.scala
@@ -12,15 +12,15 @@ import java.io.{ByteArrayOutputStream => BAOS, ByteArrayInputStream => BAIS}
 import JZlib._
 
 class WrapperTypeTest extends AnyFlatSpec with BeforeAndAfter with Matchers {
-  val data = "hello, hello!".getBytes
+  private val data = "hello, hello!".getBytes
 
-  val comprLen = 40000
-  val uncomprLen = comprLen
-  var compr:Array[Byte] = _
-  var uncompr:Array[Byte] = _
-  var err: Int = _
+  private val comprLen = 40000
+  private val uncomprLen = comprLen
+  private var compr:Array[Byte] = _
+  private var uncompr:Array[Byte] = _
+  private var err: Int = _
 
-  val cases =      /* success */        /* fail */ 
+  private val cases = /* success */     /* fail */ 
     List((W_ZLIB, (List(W_ZLIB, W_ANY), List(W_GZIP, W_NONE))),
          (W_GZIP, (List(W_GZIP, W_ANY), List(W_ZLIB, W_NONE))),
          (W_NONE, (List(W_NONE, W_ANY), List(W_ZLIB, W_GZIP))))