Support RFC 8308 + support several Tectia (ssh.com) algorithms #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norrisjeremy
force-pushed
the
20210823
branch
from
2854b3e
to
126fbac
Compare
norrisjeremy
changed the title
norrisjeremy
changed the title
norrisjeremy
changed the title
- diffie-hellman-group14-sha224@ssh.com - diffie-hellman-group14-sha256@ssh.com - diffie-hellman-group15-sha256@ssh.com - diffie-hellman-group15-sha384@ssh.com - diffie-hellman-group16-sha384@ssh.com - diffie-hellman-group16-sha512@ssh.com - diffie-hellman-group18-sha512@ssh.com - diffie-hellman-group-exchange-sha224@ssh.com - diffie-hellman-group-exchange-sha384@ssh.com - diffie-hellman-group-exchange-sha512@ssh.com - hmac-sha224@ssh.com - hmac-sha256@ssh.com - hmac-sha256-2@ssh.com - hmac-sha384@ssh.com - hmac-sha512@ssh.com - ssh-rsa-sha224@ssh.com - ssh-rsa-sha256@ssh.com - ssh-rsa-sha384@ssh.com - ssh-rsa-sha512@ssh.com
norrisjeremy
force-pushed
the
20210823
branch
from
5cb2f79
to
6e33cd1
Compare
norrisjeremy
changed the title
norrisjeremy
changed the title
|
FYI, in addition to testing the Tectia (ssh.com) algorithms against the AsyncSSH library, I also wrote a local integration test against the actual Tectia SSH server and the new algorithms in this PR seemed to work fine with it as well. |
norrisjeremy
force-pushed
the
20210823
branch
from
6e33cd1
to
2f985b9
Compare
…er instead of attempting to use Implementation Version from MANIFEST.MF.
…ost_key_types system property & also fix minor formatting issues.
norrisjeremy
force-pushed
the
20210823
branch
from
2f985b9
to
911358b
Compare
norrisjeremy
force-pushed
the
20210823
branch
from
f41947c
to
436a24d
Compare
norrisjeremy
force-pushed
the
20210823
branch
from
436a24d
to
bb76299
Compare
norrisjeremy
force-pushed
the
20210823
branch
from
d77a294
to
2bd3015
Compare
Closed
norrisjeremy
force-pushed
the
20210823
branch
5 times, most recently
from
ef1e8be
to
f314e02
Compare
norrisjeremy
force-pushed
the
20210823
branch
from
aabd39d
to
511384b
Compare
|
Thanks @norrisjeremy |
mwiede
reviewed
Sep 6, 2021
Comment on lines
+69
to
+101
| * [0.1.66](https://github.com/mwiede/jsch/releases/tag/jsch-0.1.66) | ||
| * Added support for [RFC 8308](https://datatracker.ietf.org/doc/html/rfc8308) extension negotiation and server-sig-algs extension | ||
| * This support is enabled by default, but can be controlled via the enable_server_sig_algs config option (or `jsch.enable_server_sig_algs` system property) | ||
| * When enabled and a server-sig-algs message is received from the server, the algorithms included by the server and also present in the PubkeyAcceptedKeyTypes config option will be attempted first when using publickey authentication | ||
| * Additionally if the server is detected as OpenSSH version 7.4, the rsa-sha2-256 & rsa-sha2-512 algorithms will be added to the received server-sig-algs as a workaround for [OpenSSH bug 2680](https://bugzilla.mindrot.org/show_bug.cgi?id=2680) | ||
| * Added support for various algorithms supported by Tectia (ssh.com): | ||
| * diffie-hellman-group14-sha224@<!-- -->ssh.com | ||
| * diffie-hellman-group14-sha256@<!-- -->ssh.com | ||
| * diffie-hellman-group15-sha256@<!-- -->ssh.com | ||
| * diffie-hellman-group15-sha384@<!-- -->ssh.com | ||
| * diffie-hellman-group16-sha384@<!-- -->ssh.com | ||
| * diffie-hellman-group16-sha512@<!-- -->ssh.com | ||
| * diffie-hellman-group18-sha512@<!-- -->ssh.com | ||
| * diffie-hellman-group-exchange-sha224@<!-- -->ssh.com | ||
| * diffie-hellman-group-exchange-sha384@<!-- -->ssh.com | ||
| * diffie-hellman-group-exchange-sha512@<!-- -->ssh.com | ||
| * hmac-sha224@<!-- -->ssh.com | ||
| * hmac-sha256@<!-- -->ssh.com | ||
| * hmac-sha256-2@<!-- -->ssh.com | ||
| * hmac-sha384@<!-- -->ssh.com | ||
| * hmac-sha512@<!-- -->ssh.com | ||
| * ssh-rsa-sha224@<!-- -->ssh.com | ||
| * ssh-rsa-sha256@<!-- -->ssh.com | ||
| * ssh-rsa-sha384@<!-- -->ssh.com | ||
| * ssh-rsa-sha512@<!-- -->ssh.com | ||
| * Added support for SHA224 to FingerprintHash | ||
| * Fixing [#52](https://github.com/mwiede/jsch/issues/52) | ||
| * Deprecate `void setFilenameEncoding(String encoding)` in favor of `void setFilenameEncoding(Charset encoding)` in `ChannelSftp` | ||
| * Added support for rsa-sha2-256 & rsa-rsa2-512 algorithms to `ChannelAgentForwarding` | ||
| * Address [#65](https://github.com/mwiede/jsch/issues/65) by adding ssh-agent support derived from [jsch-agent-proxy](https://github.com/ymnk/jsch-agent-proxy) | ||
| * See `examples/JSchWithAgentProxy.java` for simple example | ||
| * ssh-agent support requires either [Java 16's JEP 380](https://openjdk.java.net/jeps/380) or the addition of [junixsocket](https://github.com/kohlschutter/junixsocket) to classpath | ||
| * Pageant support is untested & requires the addition of [JNA](https://github.com/java-native-access/jna) to classpath |
There was a problem hiding this comment.
@norrisjeremy I think we should put release notes at the releases in the futures. Otherwise one gets lost on the readme.
There was a problem hiding this comment.
Do you mean splitting them out into a ChangeLog.md?
|
No, I think we can collect "features" on the readme.md, but changes can be
set on a release page on github itself. Otherwise it would be just
duplicated information.
…On Mon, Sep 6, 2021 at 2:25 PM Jeremy Norris ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Readme.md
<#64 (comment)>:
> +* [0.1.66](https://github.com/mwiede/jsch/releases/tag/jsch-0.1.66)
+ * Added support for [RFC 8308](https://datatracker.ietf.org/doc/html/rfc8308) extension negotiation and server-sig-algs extension
+ * This support is enabled by default, but can be controlled via the enable_server_sig_algs config option (or `jsch.enable_server_sig_algs` system property)
+ * When enabled and a server-sig-algs message is received from the server, the algorithms included by the server and also present in the PubkeyAcceptedKeyTypes config option will be attempted first when using publickey authentication
+ * Additionally if the server is detected as OpenSSH version 7.4, the rsa-sha2-256 & rsa-sha2-512 algorithms will be added to the received server-sig-algs as a workaround for [OpenSSH bug 2680](https://bugzilla.mindrot.org/show_bug.cgi?id=2680)
+ * Added support for various algorithms supported by Tectia (ssh.com):
+ * diffie-hellman-group14-sha224@<!-- -->ssh.com
+ * diffie-hellman-group14-sha256@<!-- -->ssh.com
+ * diffie-hellman-group15-sha256@<!-- -->ssh.com
+ * diffie-hellman-group15-sha384@<!-- -->ssh.com
+ * diffie-hellman-group16-sha384@<!-- -->ssh.com
+ * diffie-hellman-group16-sha512@<!-- -->ssh.com
+ * diffie-hellman-group18-sha512@<!-- -->ssh.com
+ * diffie-hellman-group-exchange-sha224@<!-- -->ssh.com
+ * diffie-hellman-group-exchange-sha384@<!-- -->ssh.com
+ * diffie-hellman-group-exchange-sha512@<!-- -->ssh.com
+ * hmac-sha224@<!-- -->ssh.com
+ * hmac-sha256@<!-- -->ssh.com
+ * hmac-sha256-2@<!-- -->ssh.com
+ * hmac-sha384@<!-- -->ssh.com
+ * hmac-sha512@<!-- -->ssh.com
+ * ssh-rsa-sha224@<!-- -->ssh.com
+ * ssh-rsa-sha256@<!-- -->ssh.com
+ * ssh-rsa-sha384@<!-- -->ssh.com
+ * ssh-rsa-sha512@<!-- -->ssh.com
+ * Added support for SHA224 to FingerprintHash
+ * Fixing [#52](#52)
+ * Deprecate `void setFilenameEncoding(String encoding)` in favor of `void setFilenameEncoding(Charset encoding)` in `ChannelSftp`
+ * Added support for rsa-sha2-256 & rsa-rsa2-512 algorithms to `ChannelAgentForwarding`
+ * Address [#65](#65) by adding ssh-agent support derived from [jsch-agent-proxy](https://github.com/ymnk/jsch-agent-proxy)
+ * See `examples/JSchWithAgentProxy.java` for simple example
+ * ssh-agent support requires either [Java 16's JEP 380](https://openjdk.java.net/jeps/380) or the addition of [junixsocket](https://github.com/kohlschutter/junixsocket) to classpath
+ * Pageant support is untested & requires the addition of [JNA](https://github.com/java-native-access/jna) to classpath
Do you mean splitting them out into a ChangeLog.md?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#64 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL6NOCUEPFPAR5VOPJKI33UASXL3ANCNFSM5CUVFBSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hmm, ok. My only thought would be that would put all the burden on your shoulders, since there wouldn't be any file in the git repo itself that contained "release notes" for myself or others to include in submitted PRs. |
|
FYI, I may have another PR submitted later today, that would enhance the new ssh-agent support to allow usage of key algorithms that are not supported in JSch due to missing algorithms support. |
|
Alright. I am fine, if we maintain a changelog.md file but I found it useful to look up release notes on the release pages |
|
ok, I will wait with the release, no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsch.enable_server_sig_algssystem property)void setFilenameEncoding(String encoding)in favor ofvoid setFilenameEncoding(Charset encoding)inChannelSftpChannelAgentForwardingexamples/JSchWithAgentProxy.javafor simple example