Niai Request: sorting displayed items by (un)locked status #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…userscripts into niai-display-sorting
Due to the internal database not being up to date with Wanikani content movements, unlocked items would end up in the locked section. This address the issue by incorporating more use of open framework in updating items
New minor version due to scope of the changes made regarding further incorporation of Wanikani Open Framework
…ts into niai-display-sorting
Forgot a change in html.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15, closes #22, and supersedes #23 as it does not seem marciska will be merging my fixes into that PR (which means it can be closed without merging if this gets merged). This has been open long enough I think it's fine to circumvent that PR with my own, especially since it keeps the commit history from his fork.
At some point in this branch I decided to bump the minor version of Niai to 4 but after this most recent pull from master I decided to revert that for the time being pending discussion with you. If you think the updates to utilize Open Framework more warrant the minor version increase then I will make another commit doing so while also updating the SHAs in user.js.
I have been using this feature in my own branch of Niai where I also made significant changes to the grid HTML (to align with how Wanikani does it; I won't be making a PR for this because it was a) unnecessary and b) has a bit of an issue with the red x's alignment I can't fix due to the nature of this new structure), and the sorting has been working really well for a while now. I think people will appreciate it.