Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance, fork/copies #25

Open
ldemailly opened this issue Jul 15, 2020 · 4 comments
Open

maintenance, fork/copies #25

ldemailly opened this issue Jul 15, 2020 · 4 comments

Comments

@ldemailly
Copy link

hi @mwitkow sorry to bug you.

I was curious if I could get your permission to take some/most of the go-flagz code and integrate it into a slightly different format (for instance using std go flags pattern and naming, a different logging/error handling etc...) probably as a new package in fortio (https://github.com/fortio/fortio) obviously I would preserve your name in the credits and copyright header but curious to get your blessing or hear objections? (do you plan on maintaining go-flagz further? is improbable-io going to?)

ps: if you want we can talk via email or twitter or linked in if that feels better

@mwitkow
Copy link
Owner

mwitkow commented Jul 16, 2020 via email

@ldemailly
Copy link
Author

Thank you for the reply, appreciated! will do and keep the Apache-2.0 license and your initial copyright and credit.

@ldemailly
Copy link
Author

ldemailly commented Jul 17, 2020

here is the outcome:
https://github.com/fortio/fortio/tree/master/dflag
(trimmed down features like etcd etc that I don't need and added unnecessary dependencies, also etcd support was broken with new etcd version)

hope it's ok

@ldemailly
Copy link
Author

I rewrote most of the code using generics and made additional improvements, also just moved it to a standalone package with minimal dependencies:

https://github.com/fortio/dflag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants