use Buffer.from to replace deprecated Buffer initialization, issue #64

mwittig · Apr 4, 2019 · 95956c5 · 95956c5
1 parent 4241672
commit 95956c5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/milight-legacy-mixin.js b/src/milight-legacy-mixin.js
@@ -17,7 +17,7 @@ var milightLegacyMixin = function() {
     if (! (byteArray instanceof Array)) {
       return Promise.reject(new Error("Array argument required"));
     }
-    var buffer = new Buffer(byteArray),
+    var buffer = Buffer.from(byteArray),
       self = this;
 
     return self._sendRequest = helper.settlePromise(self._sendRequest).then(function () {

diff --git a/src/milight-v6-mixin.js b/src/milight-v6-mixin.js
@@ -99,7 +99,7 @@ var milightV6Mixin = function() {
   };
 
   this._rpcCall = function (byteArray) {
-    var buffer = new Buffer(calcChecksum(byteArray)),
+    var buffer = Buffer.from(calcChecksum(byteArray)),
       self = this;
 
     return this._sendRequest = helper.settlePromise(this._sendRequest).then(function () {

diff --git a/test/legacy.js b/test/legacy.js
@@ -28,7 +28,7 @@ describe("Testing transmission of control sequences", function () {
                 bytesReceived.push(msg[x]);
             }
             if (msg.toString() === Buffer([0x4C, 0x69, 0x6E, 0x6B, 0x5F, 0x57, 0x69, 0x2D, 0x46, 0x69]).toString()) {
-                var message = new Buffer("10.10.10.10,AABBCCDDEEFF");
+                var message = Buffer.from("10.10.10.10,AABBCCDDEEFF");
                 server.send(message, 0, message.length, remote.port, remote.address);
             }
         });

diff --git a/test/v6.js b/test/v6.js
@@ -38,23 +38,23 @@ describe("Testing transmission of control sequences", function () {
             0x48, 0x52, 0x45, 0x41,
             0x44
           ]).toString()) {
-          var message = new Buffer("10.10.10.10,AABBCCDDEEFF");
+          var message = Buffer.from("10.10.10.10,AABBCCDDEEFF");
           server.send(message, 0, message.length, remote.port, remote.address);
         }
         else if (msg[0] === 0x80) {
-          var message = new Buffer([0x88,0x00,0x00,0x00,0x03,0x00,0x07,0x00]);
+          var message = Buffer.from([0x88,0x00,0x00,0x00,0x03,0x00,0x07,0x00]);
           server.send(message, 0, message.length, remote.port, remote.address);
         }
         else if (msg[0] === 0x20) {
-          var message = new Buffer([
+          var message = Buffer.from([
             0x28,0x00,0x00,0x00,0x11,0x00,0x02,0xF0,
             0xFE,0x6B,0x16,0xB1,0x50,0x50,0xAA,0x4F,
             0x76,0x00,0x01,0xED,0x01,0x00
           ]);
           server.send(message, 0, message.length, remote.port, remote.address);
         }
         else if (msg[0] === 0xFF) {
-          var message = new Buffer([
+          var message = Buffer.from([
             0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF
           ]);
           server.send(message, 0, message.length, remote.port, remote.address);