Return current window location href as API url #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Can you please include a new build of the FE too? That way, it'll be available in All you need to do is run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the API URL which is used by the frontend is always the same like the URL for the frontend itself.
Only if the frontend is loaded from localhost / 127.0.0.1, i.e. during local development of the frontend, the API call is sent towards winderoo.local, i.e. to the backend running on the ESP32.
This is a workaround for the mDNS issue on Android in #39 and should hopefully not break anything else. With this it's possible to load the frontend from the ESP32 IP instead of the winderoo.local domain provided by mDNS.