Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 3.12 Wheels And Update Pyproject #15

Merged
merged 14 commits into from
Feb 11, 2024
Merged

Build 3.12 Wheels And Update Pyproject #15

merged 14 commits into from
Feb 11, 2024

Conversation

mikedh
Copy link
Contributor

@mikedh mikedh commented Feb 2, 2024

Thanks for maintaining these bindings! I went down a slight rabbit hole trying to get Python 3.12 wheels built:

  • updates cibuildwheel version to build wheels for 3.7-3.12
    • dropped 3.6 as it needs special handling (for TOML) and also has been unsupported since 2021
  • moves most project info from setup.py to pyproject.toml
  • adds test extra, i.e. pip install xatlas[test]
    • cibuildwheel installs this extra and runs tests on every wheel
  • adds numpy as a dependency to fix import on a pip install
  • updates extern/xatlas to the latest upstream commit. It doesn't look like there's been much changed.
  • updated tests
    • now uses file relative paths for loading models so they can be run from any working directory.
    • returned width and height appear to not be totally deterministic or set explicitly (i.e. 1067 on x64, 996 on i686, old test was == 1057) so I just set the check to be >= 900.
    • on some platforms these tests are very very slow (220s) which on investigation is actually the test command compiling numpy. I left everything that succeeded even if it was making the matrix slow. The actual tests run very quickly.

This is currently building all wheels successfully.

@mworchel
Copy link
Owner

mworchel commented Feb 6, 2024

Thank you so much for investing the time! All changes look good to me.

Just a last question before I merge: do you have any idea, why the tests succeeded before but are failing now? This seems to be limited to x86 builds (?), have they been included before? I am wondering because non-deterministic atlas size doesn't seem like it would be intended. Maybe a bug in xatlas?

@mworchel mworchel merged commit ff6541e into mworchel:main Feb 11, 2024
18 checks passed
@mworchel
Copy link
Owner

Anyway, the PR is merged and version 0.0.9 is released. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants