Version 1.7.0 #225
Version 1.7.0 #225
Conversation
mwouts
commented
Feb 4, 2024
•
mwouts
commented
- Closes Add Quarto to supported editors #179
- Closes VSCode Loading #216
- Closes Itables fails to display tables in a copy of a notebook when the original notebook is already opened in Jupyter Lab #222
- Closes FutureWarning: Setting an item of incompatible dtype is deprecated and will raise an error in a future version of pandas #223
| </script> | ||
| <style>dt_css</style> | ||
| <script>jquery_src</script> | ||
| <script>window._datatables_src_for_itables = "dt_src"</script> |
There was a problem hiding this comment.
This works and looks much simpler to me than the previous promise. Now window._datatables_src_for_itables is set when itables.init_notebook_mode is called, and its value is the base64 encoding of the datatables.net library.
Then for every table in the HTML document we do
const dt = (await import(window._datatables_src_for_itables)).default;which might cause some redundancy (unless import has a cache?).
IMO that's worth the simplification, and in practice I don't notice any performance difference. I also have hopes that this can solve an intermittent issue in VS Code (#216 ).
@fwouts may I ask if you see any problem with repeating the import like this?
There was a problem hiding this comment.
I think this is likely cached and so would be fine! You could try adding a simple console.log("Hello, World!") statement in the base64-encoded window. _datatables_src_for_itables to make sure it's only logged once for multiple tables.
Don't activate datatables twice
to avoid a `pandas==2.2.0` warning: FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas.
mwouts
force-pushed
the
version_1.7.0
branch
2 times, most recently
from
7daaf71
to
118cfb2
Compare
Add data-quarto-disable-processing="true" to the tables that are not generated with to_html
Remove unnecessary dom arguments
