-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITables Version 2.0 #235
ITables Version 2.0 #235
Conversation
67a97ca
to
8a873a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 96.90% 96.24% -0.66%
==========================================
Files 26 26
Lines 1001 1013 +12
==========================================
+ Hits 970 975 +5
- Misses 31 38 +7 ☔ View full report in Codecov by Sentry. |
import dt from 'https://cdn.datatables.net/1.12.1/js/jquery.dataTables.mjs'; | ||
dt($); | ||
import 'https://code.jquery.com/jquery-3.7.1.min.js'; | ||
import 'https://cdn.datatables.net/v/dt/jszip-3.10.1/dt-2.0.1/b-3.0.0/b-html5-3.0.0/datatables.min.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllanJard, this works in a web browser and in Jupyter, but unfortunately not in VS Code (which complains that DataTable
below is not defined). Would you have .mjs
extensions for the bundles ? Or do you think you could export DataTable
explicitly in the .js
file? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am moving this conversation to #237
There are no plans for a single combined file with ESM exports at this time. But each individual module does have an ESM file - e.g.:
So just the same as the UMD loader file names with with |
Thanks @AllanJard , I'll try that, then! |
Build a bundled version that includes buttons with esbuild
1555786
to
e380c2c
Compare
5cafb92
to
2be85d1
Compare
Add support for Python 3.12 Update .github/workflow
2be85d1
to
dfa31c0
Compare
An exciting overview of what we can do with the v2 / the datatable extensions is available in the future documentations, on binder: https://mybinder.org/v2/gh/mwouts/itables/latest_dt_use_imports?urlpath=lab/tree/docs/extensions.md. I love the SearchBuilder and SearchPanes extensions! Unfortunately there is one major issue upholding this release: #238 . Now that we have a rc (thanks @mahendrapaipuri) I will reach out to the Quarto maintainers. Re #237 I am not yet sure what to do: I think import maps are not an option, reverting to datatables==1.12.1 is not an option neither, and I don't have the know-how to host esm bundles 😉 |
Remove documentation on ColReorder
0a00f97
to
8d2c14e
Compare
8d2c14e
to
c5a0fdc
Compare
This PR transitions to
datatables-net==2.0.1
. It also provides support for the a series of extension and JS bigints.Closes #50
Closes #121
Closes #172
Closes #178
Closes #207
Closes #208
Closes #231
TODO
opt.css
still useful? Do we need both thecss
and thestyle
argument?npm
during the package build?connected=True
in itables==2.0.0rc0 #237)dt_bundle
is missing ATM)