Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate .scm file extension with Scheme scripts #192

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

bzinberg
Copy link
Contributor

Scheme support is already in place. This PR associates the .scm file extension with Scheme scripts, and extends the test to test that extension along with the existing .ss extension.

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #192 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   99.44%   99.36%   -0.08%     
==========================================
  Files          61       61              
  Lines        5537     5538       +1     
==========================================
- Hits         5506     5503       -3     
- Misses         31       35       +4
Impacted Files Coverage Δ
jupytext/languages.py 100% <ø> (ø) ⬆️
tests/test_mirror.py 100% <100%> (ø) ⬆️
tests/test_read_simple_scheme.py 100% <100%> (ø) ⬆️
jupytext/pep8.py 95.23% <0%> (-4.77%) ⬇️
jupytext/cell_reader.py 98.75% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219dc18...8a70f4f. Read the comment docs.

@mwouts
Copy link
Owner

mwouts commented Feb 27, 2019

Thanks @bzinberg for your contribution. Definitely we should include this!

@mwouts
Copy link
Owner

mwouts commented Feb 27, 2019

By the way, I see there is an issue with the tests (pypy and Python 3.4, when jupytext is executed through subcommand). The issue is not related to your contribution, please ignore it.

@mwouts mwouts merged commit dda117f into mwouts:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants